fix: InstallTasks fails when settings WinRM lines lack dollar sign (2.0.9-SAC)

Defer login_monitor.settings.ps1 dot-source until after -InstallTasks so broken WinRM assignments cannot abort task registration. Deploy repairs settings lines missing $ before variable names.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-06-03 10:14:17 +10:00
parent 33367b05a8
commit 7b83a19db0
3 changed files with 58 additions and 6 deletions
+36
View File
@@ -500,6 +500,41 @@ function Test-RdpMonitorSettingsNeedsWinRmInboundBlock {
return $false
}
function Repair-RdpMonitorSettingsWinRmLinesIfInvalid {
param([string]$LocalSettings)
if (-not (Test-Path -LiteralPath $LocalSettings)) { return $false }
$c = Get-RdpMonitorSettingsRaw -Path $LocalSettings
if ([string]::IsNullOrWhiteSpace($c)) { return $false }
$winRmNames = @(
'EnableWinRmInboundMonitoring',
'WinRmLogName',
'WinRmInboundShellEventIds',
'WinRmCorrelateSecurity4624',
'WinRm4624CorrelationWindowSeconds',
'WinRmIgnoreLocalSource',
'WinRmIgnoreMachineAccounts'
)
$newContent = $c
$fixed = $false
foreach ($name in $winRmNames) {
$escaped = [regex]::Escape($name)
$pattern = "(?m)^(\s*)(?<![\$])$escaped(\s*=)"
if ($newContent -match $pattern) {
$newContent = [regex]::Replace($newContent, $pattern, ('${1}$' + $name + '${2}'))
$fixed = $true
}
}
if (-not $fixed) { return $false }
$bak = "$LocalSettings.bak.$(Get-Date -Format 'yyyyMMdd_HHmmss')"
Copy-Item -LiteralPath $LocalSettings -Destination $bak -Force
[System.IO.File]::WriteAllText($LocalSettings, $newContent.TrimEnd() + "`r`n", $Utf8Bom)
Write-DeployLog "login_monitor.settings.ps1: исправлены WinRM-строки без `$ (резервная копия: $bak)"
return $true
}
function Sync-RdpMonitorSettingsWinRmInboundBlock {
param([string]$LocalSettings)
if (-not (Test-Path -LiteralPath $LocalSettings)) { return $false }
@@ -597,6 +632,7 @@ function Invoke-RdpMonitorSettingsPostPatches {
if (Update-RdpMonitorSettingsServerDisplayNameHintIfMissing -LocalSettings $LocalSettings) { $changed = $true }
if (Sync-RdpMonitorSettingsDailyReportPatches -LocalSettings $LocalSettings) { $changed = $true }
if (Sync-RdpMonitorSettingsExchangeNoisePatches -LocalSettings $LocalSettings) { $changed = $true }
if (Repair-RdpMonitorSettingsWinRmLinesIfInvalid -LocalSettings $LocalSettings) { $changed = $true }
if (Sync-RdpMonitorSettingsWinRmInboundBlock -LocalSettings $LocalSettings) { $changed = $true }
return $changed
}
+21 -5
View File
@@ -82,7 +82,7 @@ $script:MonitorStopRequested = $false
# строки ниже, если правки «мелкие» и вы не хотите менять отображаемую версию в логах).
# Рекомендация: при значимых релизах меняйте и $ScriptVersion, и version.txt одинаково; при только
# исправлениях на шаре — достаточно поднять patch в version.txt (например 1.3.0.1).
$ScriptVersion = "2.0.8-SAC"
$ScriptVersion = "2.0.9-SAC"
# Логи (все под InstallRoot)
$LogFile = Join-Path $script:InstallRoot "Logs\login_monitor.log"
@@ -230,10 +230,6 @@ $SacFallbackFailures = 5
$script:LoginMonitorSettingsFile = Join-Path $script:InstallRoot 'login_monitor.settings.ps1'
$script:LoginMonitorSettingsLoaded = $false
if (Test-Path -LiteralPath $script:LoginMonitorSettingsFile) {
. $script:LoginMonitorSettingsFile
$script:LoginMonitorSettingsLoaded = $true
}
# ============================================
# ИНИЦИАЛИЗАЦИЯ
@@ -655,6 +651,24 @@ if ($InstallTasks) {
exit 0
}
function Import-LoginMonitorSettingsFile {
if ($script:LoginMonitorSettingsLoaded) { return $true }
if (-not (Test-Path -LiteralPath $script:LoginMonitorSettingsFile)) { return $false }
try {
. $script:LoginMonitorSettingsFile
$script:LoginMonitorSettingsLoaded = $true
return $true
} catch {
$msg = $_.Exception.Message
if (Get-Command Write-Log -ErrorAction SilentlyContinue) {
Write-Log "ОШИБКА: login_monitor.settings.ps1 — $msg"
} else {
Write-Host "ОШИБКА: login_monitor.settings.ps1 — $msg"
}
exit 1
}
}
# Только запись restart.request — без проверки администратора (Deploy/GPO может вызывать из SYSTEM).
if ($RequestRestart) {
$restartMode = if ($Recycle) { 'recycle' } else { 'settings' }
@@ -663,6 +677,8 @@ if ($RequestRestart) {
exit 0
}
Import-LoginMonitorSettingsFile | Out-Null
# --- Учётные данные Telegram (открытый текст или DPAPI Base64) ---
if (-not [string]::IsNullOrWhiteSpace($TelegramBotTokenProtectedB64)) {
try {
+1 -1
View File
@@ -1 +1 @@
2.0.8-SAC
2.0.9-SAC